-
Notifications
You must be signed in to change notification settings - Fork 10
Modernize repo and make sure it works with ST4 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
AFAICT the tests **must** be run in Sublime Using <https://github.com/SublimeText/UnitTesting> probably helps (and it can also run the tests in GitHub Actions).
|
Okay. The tests run now (I spent quite a lot of time discovering I had |
|
I also intend on completely changing the algorithm for detecting a modeline. The rationale for that is we allow changing the syntax of the file, which means the comment char will probably incorrect if the syntax of the file is incorrect… I think we could probably have the tokens like so (full-line regex): (We assume here no comment will need to end with a That would make any of these modelines recognized: And those would not be recognized: What do you think? EDIT: Syntax changes. |
|
You don't think |
It’s meaningless, but the test pass!
|
It’s very edge-casy, but there is dnl. |
|
If you want to check ST3 compat, UnitTesting has a GH Action that can do it for you. There's probably not any divergence between platforms, so ST3, ST4 on Ubuntu is probably enough. If you have CI minutes to burn. 😅 |
|
Yes I noticed the UnitTesting repo has a GitHub Actions for testing in the CI and thought about setting that up. Thanks for the review! I have not finalized everything yet, the PR is still a draft for now (I have to implement the format change, cleanup the tests even more, etc.) I will do the changes you proposed/requested before marking the PR ready. |
That being said: