Vim compatibility, ST3 compatibility #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks great. I'll be reviewing this when I find time, but just a question: do you use Vintageous by any chance? If so, Modelines has been integrated with it. It'd be great to include this changes there as well, and use the Vintageous' test framework. |
|
This PR introduces some errors because of typos in the code: MerlinDMC@b858efa#diff-59bf0efa5b9225902b4ded2288b9b7a9 |
|
Any update on this? Just noticed that it doesn't work at all in ST3 :( |
|
@kaithar You can fetch from the fork if you want it: https://github.com/MerlinDMC/Modelines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added ST3 compatibility and VIM-Style modeline compatibility. There are now even partly vim modelines supported.
Kind Regards, Kiwi