Add support for Ruby 4.0 #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryansch
reviewed
Jan 2, 2026
abrom
reviewed
Jan 14, 2026
.github/workflows/test.yml
Outdated
| puppeteer-version: '24.10.2' | ||
| - ruby-version: '3.4' | ||
| node-version: '24' | ||
| puppeteer-version: '24.10.2' |
Contributor
There was a problem hiding this comment.
we can also get rid of these
grover.gemspec
Outdated
| spec.homepage = 'https://github.com/Studiosity/grover' | ||
| spec.license = 'MIT' | ||
| spec.required_ruby_version = ['>= 3.0.0', '< 3.5.0'] | ||
| spec.required_ruby_version = ['>= 3.0.0', '< 5.0.0'] |
Contributor
There was a problem hiding this comment.
limiting to < 4.1 is likely safer.. we don't really know what the future of the language will be. In all likelihood it won't be a problem, but that isn't how the history of the language has evolved 😄
Closed
Contributor
|
Released in v1.2.5 |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
grover.gemspecto allow Ruby versions up to 4.1.0.github/workflows/test.ymlto include Ruby 4.0 in the test matrix with Node.js 18, 20, 22, and 24spec/spec_helper.rbto check for nil before callingempty?on puppeteer versionCHANGELOG.mdto document Ruby 4.0 supportTesting
All existing tests pass with Ruby 4.0.0. The gem is fully compatible with Ruby 4.0.