Fix to correct internal fillet radius on concave edges of custom bins.#147
Merged
Stu142 merged 3 commits intoMar 4, 2026
Merged
Conversation
…ins. Adds `vertical_edge_fillet_with_concave_edges()` function that applies different fillet radii to concave and convex vertical edges of a solid. This is used by `CustomStorageBin` to apply a larger fillet radius to vertical edges of the compartments which correspond to externally concave edges.
glenn20
force-pushed
the
fix-custom-bins-concave-edge-radius
branch
from
1cc3db7 to
01d3073
Compare
Owner
|
Neat addition, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses a different fillet radius for the internal compartments at "concave" edges of custom bins shapes. These edges require a larger fillet radius than the usual "convex" edges of ordinary bins (See the first diagram).
Adds
vertical_edge_fillet_with_concave_edges()function tocustom_shape_features.pythat applies different fillet radii to concave and convex vertical edges of a solid.This is used by
CustomStorageBinto apply a larger fillet radius to vertical edges of the compartments which correspond to externally concave edges.The first image shows the effect of the incorrect radius on concave edges (WallThickness=2.0mm). The second image shows the "correct" radius used on those edges.