You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Checks for lower divider height and lowers fillets to match.
If x and y divider heights are different the fillets will only go up to the lower one as they are just and extruded cut and can't differentiate between the different scenarios.
I think this is acceptable as there are probably limited users using both at a different height and it still works.
If x and y divider heights are different the fillets will only go up to the lower one as they are just and extruded cut and can't differentiate between the different scenarios.
The taller fillets should be the ones adjacent to the bin walls that are perpendicular to the higher divider, all other fillets should be shorter.
In code, you can for example:
First, iterate over the divider intersections and create 4 fillets that are adjacent to the divider intersection of height $min(h_x, h_y)$ (in a doubly nested for loop).
Then create fillets that touch bin walls by two separate for loops
a. one loop creates fillets that touch $x$-plane wall of the bin with height $h_x$
b. second loop creates fillets that touch $y$-plane wall of the bin of height $h_y$
Also I think it's a good opportunity to extract the common code of _make_compartments_with_deviders and make_eco_compartments to a helper function, as I see you are making exactly the same changes in these two functions.
I see refactoring is planned around fillet generation, so let me post it here as this is likely related. Even with the a single divider on a simple gridfinity without a lip (I think this is the culprit) the fillet does not reach the top.
I see refactoring is planned around fillet generation, so let me post it here as this is likely related. Even with the a single divider on a simple gridfinity without a lip (I think this is the culprit) the fillet does not reach the top.
This effect has been fixed in PR #135 (merged in v0.12.1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Fix for #124
Checks for lower divider height and lowers fillets to match.
If x and y divider heights are different the fillets will only go up to the lower one as they are just and extruded cut and can't differentiate between the different scenarios.
I think this is acceptable as there are probably limited users using both at a different height and it still works.