Wrap callback in extern "C" block.#2
Open
Kerilk wants to merge 1 commit into
Open
Conversation
Author
|
@MathiasMagnus does this makes sense to you? do you want me to make a similar pull request on the layer repo, but for all C++ layers? |
|
@Kerilk I totally agree, having them in an extern c block would be cleaner. This branch is the source branch of an already merged PR to upstream, so I may just cherry pick this commit on our next PR, just to keep attribution. |
Author
|
Let's proceed as you see best. I can also just redo this on all the layers on the OpenCL repo as well and open a PR there, just tell me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably me being pedantic, but the dispatch table is defined inside an
extern "C"block, while the callbacks were not. This shouldn't have been a problem, but this feels cleaner.I created a pull request (rather than a suggestion) in order to have the CI validate the change.
CI ran: see https://github.com/Kerilk/OpenCL-Layers/actions/runs/2282819938 and https://github.com/Kerilk/OpenCL-Layers/actions/runs/2282819937
edit: if this looks good, I will make a separate pull-request for the other layers