Skip to content

fix: don't add values to user status field#51

Merged
StevanFreeborn merged 0 commit into
mainfrom
stevanfreeborn/fix/50-address-list-values-being-added-to-user-status-field
Aug 19, 2025
Merged

fix: don't add values to user status field#51
StevanFreeborn merged 0 commit into
mainfrom
stevanfreeborn/fix/50-address-list-values-being-added-to-user-status-field

Conversation

@StevanFreeborn

Copy link
Copy Markdown
Owner

closes #50

  • fix: address status value issue
  • chore: stub out test
  • tests: add test to ensure list values for user status field are not added to Onspring

@StevanFreeborn StevanFreeborn self-assigned this Aug 19, 2025
@StevanFreeborn StevanFreeborn requested a review from Copilot August 19, 2025 15:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where values were being incorrectly added to the user status field in Onspring. The fix prevents the system from adding list values to the user status field, which was causing unintended behavior.

  • Added a conditional check to skip processing when the field ID matches the user status field ID
  • Implemented comprehensive test coverage to verify the fix works correctly
  • Removed an extraneous empty line for code cleanup

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Models/Processor.cs Added conditional logic to skip adding values to user status field and minor whitespace cleanup
tests/UnitTests/ProcessorTests.cs Added comprehensive test to verify user status field values are not added to Onspring

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov

codecov Bot commented Aug 19, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.10%. Comparing base (8ab3308) to head (3b3dfd1).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/Models/Processor.cs 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   97.15%   97.10%   -0.05%     
==========================================
  Files          10       10              
  Lines        1830     1833       +3     
  Branches      158      159       +1     
==========================================
+ Hits         1778     1780       +2     
  Misses         38       38              
- Partials       14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StevanFreeborn StevanFreeborn merged this pull request into main Aug 19, 2025
4 of 6 checks passed
@StevanFreeborn StevanFreeborn deleted the stevanfreeborn/fix/50-address-list-values-being-added-to-user-status-field branch August 19, 2025 15:48
StevanFreeborn added a commit that referenced this pull request Apr 10, 2026
…ess-list-values-being-added-to-user-status-field

fix: don't add values to user status field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: The value "True" is being added to the Status field list in the Users application

2 participants