fix: don't add values to user status field#51
Merged
StevanFreeborn merged 0 commit intoAug 19, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where values were being incorrectly added to the user status field in Onspring. The fix prevents the system from adding list values to the user status field, which was causing unintended behavior.
- Added a conditional check to skip processing when the field ID matches the user status field ID
- Implemented comprehensive test coverage to verify the fix works correctly
- Removed an extraneous empty line for code cleanup
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Models/Processor.cs | Added conditional logic to skip adding values to user status field and minor whitespace cleanup |
| tests/UnitTests/ProcessorTests.cs | Added comprehensive test to verify user status field values are not added to Onspring |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 97.15% 97.10% -0.05%
==========================================
Files 10 10
Lines 1830 1833 +3
Branches 158 159 +1
==========================================
+ Hits 1778 1780 +2
Misses 38 38
- Partials 14 15 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
StevanFreeborn
added a commit
that referenced
this pull request
Apr 10, 2026
…ess-list-values-being-added-to-user-status-field fix: don't add values to user status field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #50