fixed tests and contract implementation

[Akatenvictor]

Pull Request Checklist

General

• PR title follows conventional commit format (type(scope): description)
• Branch name follows issue-<number>-<description> format
• Linked to relevant issue(s) with Closes #<number> or Fixes #<number>
• Description clearly explains what changes were made and why
• Breaking changes documented (if applicable)
  This PR adds critical test coverage for yield claiming scenarios that ensure the robustness and correctness of the vault's yield distribution system

Code Quality

• Code follows project style guidelines (make fmt passes)
• No clippy warnings (make lint passes)
• No new panic! statements (use panic_with_error! instead)
• Public functions have proper documentation
• Complex logic is explained with comments

Testing

• All existing tests still pass (make test passes)
• New functionality is covered by tests
• Test coverage meets minimum requirements (90%+ for new features)
• Tests follow naming conventions (test_<functionality>_scenario)
• Edge cases and error conditions are tested

Security & Events

• Access control properly implemented and tested
• All state changes emit appropriate events
• Input validation is comprehensive
• Reentrancy protection where needed
• CEI pattern (Checks-Effects-Interactions) followed

Documentation

• README updated (if applicable)
• API documentation updated (if applicable)
• Architecture docs updated (if applicable)
• Examples added or updated (if applicable)

Description

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)
• Performance improvement
• Security improvement

Testing

Security Considerations

Screenshots / Diagrams

Additional Context

Reviewer Focus Areas

---

By submitting this PR, I confirm that:

• I have read and followed the contribution guidelines
• My code follows the project's style standards
• I have performed a self-review of my code
• I have added tests that prove my fix is effective or that my feature works
• I have tested my changes thoroughly
• I understand that this PR may be closed if I don't respond to feedback in a timely manner

Closes #193
Closes #177
Closes #178
Closes #209

[drips-wave]

@Akatenvictor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits