Perf/lightweight modal state#228
Open
binayyub4211 wants to merge 4 commits into
Open
Conversation
|
@binayyub4211 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #170
fix: optimize modal memory footprint with short-circuit rendering expressions
Description
What was done:
Migrated heavily mounted structural modal overlays to state-driven on-demand rendering.
Modified
src/app/components/nav.jsx
to mount the wallet connection and anomaly alert dialogs only when their triggers are active.
Updated
src/app/governance/page.tsx
to render the proposal submission form conditionally.
Edited
src/app/relayers/page.tsx
to wire the registration modal to on-demand rendering.
Cleaned up
src/app/consumers/page.tsx
by importing missing style variants from classNameVariants.ts and configuring state-driven provision access forms.
Extended
src/app/staking/page.tsx
to handle dynamic APY adjustment and manual slashing forms via conditional rendering hooks.
Styled all newly added interactive overlays using uniform glassmorphic backdrops, premium gradients, HSL tailored variables, and micro-animations.
Why it was done:
Closed modals were retaining heavy node structures in the active DOM tree, leading to layout memory bloat and reduced UI responsiveness during heavy rendering updates. Utilizing short-circuit rendering expressions ensures closed modals have a zero DOM footprint.
How it was verified:
Performed static type analysis on all new lifecycle structures.
Verified layout alignment, prop definitions, and custom state hooks statically.
Updated the local progress tracking checklist inside the task list.