perf: refactor contracts page theme switching to use css variables#224
Open
AbuJulaybeeb wants to merge 1 commit into
Open
perf: refactor contracts page theme switching to use css variables#224AbuJulaybeeb wants to merge 1 commit into
AbuJulaybeeb wants to merge 1 commit into
Conversation
|
@AbuJulaybeeb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed React useState (isHalted) from src/app/contracts/page.tsx.
Refactored the layout to use a top-level container with id="contracts-page-container" and data-status attribute.
Created CSS variables --status-bg, --status-border, --status-icon-color, --status-btn-bg, --status-btn-hover-bg, --status-btn-text, and --status-btn-shadow in src/app/globals.css that adapt to the data-status attribute.
Configured visibility classes (.active-only and .halted-only) to switch elements and texts purely through CSS selectors.
Added a direct DOM modification handler handleHaltToggle to update the data-status attribute on click, eliminating React tree reconciliation during theme switching.
Why it was done
Using React state to manage localized theme changes triggered whole-page re-renders. Toggling the theme via CSS variables and parent attribute selection avoids React reconciliation completely, improving UI performance.
How it was verified
Verified using npm run build to confirm compilation correctness of the modified files.
Closes #99