Perf | Passive Scrolling Event Attachment#219
Open
Menjay7 wants to merge 1 commit into
Open
Conversation
|
@Menjay7 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Overview
This PR improves scrolling performance by updating scroll-related event listeners to use passive event attachment where appropriate.
Problem
Certain scrolling event listeners were attached without the passive option, causing the browser to wait for potential preventDefault() calls before continuing scroll execution. This could negatively impact:
scroll smoothness
rendering responsiveness
mobile performance
overall user experience
Changes Made
Updated scroll and touch event listeners to use { passive: true }
Removed unnecessary blocking behavior from non-cancelable listeners
Improved event listener handling consistency across the application
Reduced main-thread work during scrolling interactions
Benefits
Smoother scrolling performance
Reduced input latency
Improved responsiveness on mobile devices
Better browser optimization for touch and wheel events
Improved Lighthouse/Web Vitals performance metrics
Testing
Verified scrolling behavior remains unchanged
Confirmed no functionality relies on prevent Default() in passive listeners
Tested across desktop and mobile environments
Validated improved scroll responsiveness during interaction..Closed #142