fix: force-clear WebSocket session from memory on disconnect#312
Merged
Sadeequ merged 1 commit intoMay 29, 2026
Merged
Conversation
On abrupt disconnect (e.g. browser tab close/refresh), the previous implementation entered a 60s grace period before removing the session, leaving dead socket connections in memory. Now handleDisconnect immediately deletes the session from the sessions map and cancels any pending disconnectTimer, preventing memory overhead from stale connections. Closes StellarFlow-Network#294
|
@nyarumyaro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #294 — corrupted WebSocket room cleanup logic.
When an admin closes or refreshes the dashboard browser tab abruptly, the backend was entering a 60-second grace period before removing the dead socket session from memory. This caused stale
disconnected-pendingentries to accumulate in thesessionsmap, creating unnecessary memory overhead.Changes
src/lib/socket.ts—handleDisconnectdisconnectTimertimeout on disconnect.sessionsmap when a disconnect event fires.disconnectTimeris cancelled before deletion to avoid dangling timers.Before / After
Testing
sessionsmap immediately (no 60s wait).