#296 📝 qa | automated pre commit linter enforcement fix

[Kappa16]

📝 QA | Automated Pre-Commit Linter Enforcement FIXED

Key Findings

The pre-commit hook was incomplete and only executed npm run style:check via lint-staged. This setup limited checks to staged files and did not run a full ESLint scan across the entire codebase. As a result, 65 existing lint errors across src/, test/, tests/, and scripts/ were not detected during commits. The hook also lacked set -e, meaning failures would not reliably block commits if additional commands were added later. The lint issues included duplicate keys and imports, missing variables, incorrect regex escapes, unused imports, incorrect TypeScript ignore usage, missing Node globals, and overly strict ESLint rules affecting valid patterns such as constants and TypeScript global declarations. Some errors also came from load test and legacy metric directories treated as false positives.

Fix Features

The pre-commit pipeline was upgraded to enforce full codebase quality checks. A full npm run lint step now runs before any staged-file fixes and blocks commits on failure. lint-staged remains in place but now executes only after the full lint pass succeeds. The hook now includes set -e to ensure immediate exit on any error. After fixes, the lint state improved from 65 errors and 63 warnings to 0 errors and 57 warnings. Commit enforcement now covers the entire repository instead of only staged files, preventing previously undetected lint issues from entering the codebase.

CLOSE #296

[drips-wave]

@Kappa16 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits