feat: implement EmptyRelayer with is_noop() pattern#305
Open
Abd-Standard wants to merge 1 commit into
Open
Conversation
- Replace undefined/null relayer returns with strictly typed EmptyRelayer - Implement is_noop() method for polymorphic relayer checks - Create relayer.types.ts with ActiveRelayer interface and EmptyRelayer class - Update Express Request type to always require relayer (never optional) - Enhance relayerMiddleware to ensure req.relayer is always initialized - Update middleware checks to use is_noop() instead of null checks - Fix signatureVerificationMiddleware and latencyGuardMiddleware - Update relayerAuth tests to verify EmptyRelayer behavior - Eliminate architectural noise from null/undefined checks downstream Implements pure OOP semantics while maintaining backward compatibility.
|
@Abd-Standard Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257
Implements pure OOP semantics while maintaining backward compatibility.