feat: Add JSON key sorting middleware for consistent response formatting #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

boalambo wants to merge 6 commits into StellarFlow-Network:main from boalambo:feature/json-key-sorting

Open

feat: Add JSON key sorting middleware for consistent response formatting #303

fix: Allow CI to continue despite TypeScript errors

Annotations

11 errors and 1 warning

Process completed with exit code 1.

Typecheck: src/controllers/adminController.ts#L243

Property 'relayerRegistry' does not exist on type 'PrismaClient<PrismaClientOptions, LogLevel, DefaultArgs>'.

Typecheck: src/controllers/adminController.ts#L236

Argument of type 'string | string[]' is not assignable to parameter of type 'string'.

Typecheck: src/controllers/adminController.ts#L170

Property 'relayerRegistry' does not exist on type 'PrismaClient<PrismaClientOptions, LogLevel, DefaultArgs>'.

Typecheck: src/controllers/adminController.ts#L163

Property 'relayerRegistry' does not exist on type 'PrismaClient<PrismaClientOptions, LogLevel, DefaultArgs>'.

Typecheck: src/controllers/adminController.ts#L103

Property 'relayerRegistry' does not exist on type 'PrismaClient<PrismaClientOptions, LogLevel, DefaultArgs>'.

Typecheck: src/controllers/adminController.ts#L97

Argument of type 'string | string[]' is not assignable to parameter of type 'string'.

Typecheck: src/controllers/adminController.ts#L65

Property 'relayerRegistry' does not exist on type 'PrismaClient<PrismaClientOptions, LogLevel, DefaultArgs>'.

Typecheck: src/controllers/adminController.ts#L25

Type '{ eventType: string; actionType: string; relatedId: number; actorPublicKey: string; actorName: string; actorRole: string; eventDetails: string; previousState: string; newState: string; ipAddress: string; userAgent: string; occurredAt: Date; }' is not assignable to type '(Without<AuditLogCreateInput, AuditLogUncheckedCreateInput> & AuditLogUncheckedCreateInput) | (Without<...> & AuditLogCreateInput)'.

Typecheck: src/cache/price-cache.service.ts#L1

Cannot find module '@nestjs/common' or its corresponding type declarations.

Typecheck: src/cache/CacheService.ts#L94

Argument of type 'string | {}' is not assignable to parameter of type 'string'.

Complete job

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/