Skip to content

feat(entries): format delimited source entry fields for display#820

Open
vcnainala wants to merge 1 commit into
developmentfrom
fix/581-entry-details-formatting
Open

feat(entries): format delimited source entry fields for display#820
vcnainala wants to merge 1 commit into
developmentfrom
fix/581-entry-details-formatting

Conversation

@vcnainala

Copy link
Copy Markdown
Member

Summary

  • Add EntryFieldFormatter service to split ##-grouped and |-separated entry field values into human-readable lists
  • Update the public Entry Details modal to render formatted DOI, link, organism, location, and related fields with clickable links
  • Apply the same formatting in Filament Collection and Report entry infolists via HtmlString
  • Add unit tests for delimiter parsing and HTML output

Closes #581

Test plan

  • Open a molecule with multi-reference collection data, click a Reference ID bookmark, and confirm ## delimiters are no longer shown raw
  • Verify DOI values link to doi.org
  • In Filament dashboard → Collection → Entries → View entry, confirm delimited fields render as grouped lists
  • php artisan test --filter=EntryFieldFormatterTest

Split ##-grouped and pipe-separated entry values into human-readable
lists in the public Entry Details modal and Filament entry views, with
clickable DOI and URL links.

Closes #581
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 49.13793% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.69%. Comparing base (4223a58) to head (1700ac1).

Files with missing lines Patch % Lines
...source/RelationManagers/EntriesRelationManager.php 0.00% 18 Missing ⚠️
...source/RelationManagers/EntriesRelationManager.php 0.00% 18 Missing ⚠️
app/Livewire/EntryDetailsDisplay.php 0.00% 16 Missing ⚠️
app/Services/EntryFieldFormatter.php 89.06% 7 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             development    #820      +/-   ##
================================================
+ Coverage           6.13%   6.69%   +0.55%     
- Complexity          1737    1765      +28     
================================================
  Files                227     228       +1     
  Lines               8961    9063     +102     
================================================
+ Hits                 550     607      +57     
- Misses              8411    8456      +45     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants