feat(entries): format delimited source entry fields for display#820
Open
vcnainala wants to merge 1 commit into
Open
feat(entries): format delimited source entry fields for display#820vcnainala wants to merge 1 commit into
vcnainala wants to merge 1 commit into
Conversation
Split ##-grouped and pipe-separated entry values into human-readable lists in the public Entry Details modal and Filament entry views, with clickable DOI and URL links. Closes #581
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## development #820 +/- ##
================================================
+ Coverage 6.13% 6.69% +0.55%
- Complexity 1737 1765 +28
================================================
Files 227 228 +1
Lines 8961 9063 +102
================================================
+ Hits 550 607 +57
- Misses 8411 8456 +45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EntryFieldFormatterservice to split##-grouped and|-separated entry field values into human-readable listsHtmlStringCloses #581
Test plan
##delimiters are no longer shown rawdoi.orgphp artisan test --filter=EntryFieldFormatterTest