fix(search): parse multi-word class and superclass filter values#819
Open
vcnainala wants to merge 1 commit into
Open
fix(search): parse multi-word class and superclass filter values#819vcnainala wants to merge 1 commit into
vcnainala wants to merge 1 commit into
Conversation
Filter queries such as class:Unsaturated+hydrocarbons were split on spaces after URL decoding, causing SQL errors. Add key-aware filter tokenization, normalize text values to hyphen slugs, and align Advanced Search encoding with existing search links. Fixes #818
vcnainala
added
PR pending
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
======================================
Coverage ? 6.13%
Complexity ? 1738
======================================
Files ? 227
Lines ? 8962
Branches ? 0
======================================
Hits ? 550
Misses ? 8412
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
class:Unsaturated+hydrocarbons,superclass:Organometallic+compounds) reported in Search fails for class and superclass names containing multiple words #818parseFilterQueryTokens()so values with spaces are not split after URL decodingREGEXP_REPLACElogicTest plan
php artisan test --filter=ParseFilterQuery(8 tests)/search?type=filters&q=class:Unsaturated+hydrocarbonsreturns results without error/search?type=filters&q=superclass:Organometallic+compoundsreturns results without error/search?type=filters&q=class:acyl-halidesstill works (regression)/search?type=filters&q=tac:4..6 mw:100..200combined AND filters still workclass:unsaturated-hydrocarbons→ search succeedsFixes #818