fix(reports): allow assigned curators to edit all report fields#809
Open
vcnainala wants to merge 1 commit into
Open
fix(reports): allow assigned curators to edit all report fields#809vcnainala wants to merge 1 commit into
vcnainala wants to merge 1 commit into
Conversation
Assigned curators were blocked from editing reports by missing Shield permissions and UPDATE-field gating tied to reporter requests. Centralize curator edit authorization on the Report model, grant curator report permissions in the seeder, and unlock all change fields on edit. Closes #738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #738.
Report::assignedCuratorCanEdit()to centralize two-curator / four-eyes edit rules on the modelReportPolicy::update()so users with thecuratorrole orupdate_reportpermission can edit when assignedview_any_report,view_report, andupdate_reportto the curator role inShieldSeederTest plan
php artisan test --filter=ReportPolicy(6 tests)SUBMITTEDUPDATE report and confirm the edit page openssuggested_changes.curatorreflects editsPENDING_APPROVAL(four-eyes)