feat(reports): sorting, email link fixes, and auth UI cleanup#808
Open
vcnainala wants to merge 4 commits into
Open
feat(reports): sorting, email link fixes, and auth UI cleanup#808vcnainala wants to merge 4 commits into
vcnainala wants to merge 4 commits into
Conversation
Expose report id and created_at as visible, sortable Filament table columns so curators and reporters can order reports by number or submission date. Fixes #769
Drop the authentication-card logo slot so the site header logo is the only branding on login and related auth pages across all breakpoints.
Use the compound route helper for molecule URLs and normalize DOI values before building markdown links to avoid malformed hrefs in notification mail. Fixes #737
Add a workflow that adds or removes the PR pending label when open pull requests reference issues using closing keywords.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #808 +/- ##
================================================
- Coverage 6.14% 6.08% -0.07%
- Complexity 1736 1737 +1
================================================
Files 227 227
Lines 8945 8970 +25
================================================
- Hits 550 546 -4
- Misses 8395 8424 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id) and Date (created_at) columns to the Filament reports list so curators and reporters can sort by report number or submission date.compoundroute and normalizing DOI values before building markdown links.Related issues
Fixes #769
Fixes #737
Test plan
php artisan test --filter=NormalizeDoiForLinkTest/dashboard/reportsand verify No. / Date column sorting/loginon mobile and desktop and confirm only one logo appears (header)