Skip to content

feat(reports): add category-aware curator approval confirmation messages#807

Open
vcnainala wants to merge 1 commit into
developmentfrom
feat/report-approval-confirmation-messages
Open

feat(reports): add category-aware curator approval confirmation messages#807
vcnainala wants to merge 1 commit into
developmentfrom
feat/report-approval-confirmation-messages

Conversation

@vcnainala

Copy link
Copy Markdown
Member

Summary

  • Add explicit approve-modal headings, descriptions, and submit labels for curators based on report category (SUBMISSION, UPDATE, REVOKE) and review stage (first vs final four-eyes approval)
  • Replace generic post-approval toast notifications with category-specific success messages
  • Add unit tests covering the approval message matrix

Closes #770

Test plan

  • php artisan test tests/Unit/ReportApprovalMessageTest.php (14 tests passing)
  • As curator 1 on a SUBMITTED UPDATE report, confirm Approve modal states changes will be forwarded, not applied
  • As curator 2 on PENDING_APPROVAL UPDATE report, confirm modal states selected changes will be applied
  • As curator 2 on PENDING_APPROVAL SUBMISSION, confirm modal states a new molecule entry will be created
  • As curator 2 on PENDING_APPROVAL REVOKE (molecule), confirm modal states the molecule will be revoked/deactivated
  • As curator 2 on REVOKE (citation/collection/organism), confirm modal warns about manual changes and status-only approval
  • Confirm success toasts match the action taken

Curators now see explicit modal headings, descriptions, and submit labels
when approving reports, distinguishing first-review forwarding from final
approval outcomes for submissions, updates, and revocations.

Closes #770
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.39785% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.02%. Comparing base (a4c26c6) to head (c8215e2).
⚠️ Report is 4 commits behind head on development.

Files with missing lines Patch % Lines
...pp/Filament/Dashboard/Resources/ReportResource.php 91.39% 8 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             development    #807      +/-   ##
================================================
+ Coverage           6.14%   7.02%   +0.87%     
- Complexity          1736    1758      +22     
================================================
  Files                227     227              
  Lines               8945    9043      +98     
================================================
+ Hits                 550     635      +85     
- Misses              8395    8408      +13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants