feat(reports): add category-aware curator approval confirmation messages#807
Open
vcnainala wants to merge 1 commit into
Open
feat(reports): add category-aware curator approval confirmation messages#807vcnainala wants to merge 1 commit into
vcnainala wants to merge 1 commit into
Conversation
Curators now see explicit modal headings, descriptions, and submit labels when approving reports, distinguishing first-review forwarding from final approval outcomes for submissions, updates, and revocations. Closes #770
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #807 +/- ##
================================================
+ Coverage 6.14% 7.02% +0.87%
- Complexity 1736 1758 +22
================================================
Files 227 227
Lines 8945 9043 +98
================================================
+ Hits 550 635 +85
- Misses 8395 8408 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUBMISSION,UPDATE,REVOKE) and review stage (first vs final four-eyes approval)Closes #770
Test plan
php artisan test tests/Unit/ReportApprovalMessageTest.php(14 tests passing)