fix(api): enable ilike filter for REST API search#806
Open
vcnainala wants to merge 2 commits into
Open
Conversation
Extend Lomkit search validation to accept the PostgreSQL ilike operator, enabling case-insensitive filtering on REST resource endpoints. Closes #335
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #806 +/- ##
================================================
+ Coverage 6.13% 7.07% +0.93%
- Complexity 1737 1744 +7
================================================
Files 227 230 +3
Lines 8961 9008 +47
================================================
+ Hits 550 637 +87
+ Misses 8411 8371 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remove empty constructor parentheses and align unary operator spacing so PHP Lint & Security passes on PR #806.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iliketo allowed Lomkit REST API search filter operators for PostgreSQL case-insensitive matchingSearchRequestvalidation via dedicatedApp\Http\Requests\Rest\SearchRequestand custom search rulesilikeonce validation passesCloses #335
Supersedes the closed PR #398, which targeted an older Lomkit API and included unnecessary
CustomBuilderwiring.Test plan
php artisan test --filter=MoleculeSearchIlikeilikematches case-insensitively (e.g.%caffeine%findsCaffeine)likeremains case-sensitive on PostgreSQL