fix(reports): request changes form validation for compounds and organisms#804
Open
vcnainala wants to merge 3 commits into
Open
fix(reports): request changes form validation for compounds and organisms#804vcnainala wants to merge 3 commits into
vcnainala wants to merge 3 commits into
Conversation
Relax unique-name validation in the request-changes organism repeater so users can link organisms that already exist in the database. Reject names already attached to the target molecule instead. Fixes #772
Align Filament v4 Select option keys with stored state for existing synonyms, CAS, geo locations, organisms, and citations. Resolve the target molecule from form state and report records so options remain valid on Livewire submit requests. Fixes #775
This was referenced Jun 7, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #804 +/- ##
================================================
+ Coverage 6.13% 6.64% +0.50%
- Complexity 1737 1749 +12
================================================
Files 227 227
Lines 8961 9012 +51
================================================
+ Hits 550 599 +49
- Misses 8411 8413 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Use explicit null checks for molecule synonyms/CAS options and remove unreachable is_string handling for mol_ids array cast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ReportResource: replace static molecule loading withresolveMolecule()/valueKeyedOptions()helpers; add hiddencompound_idandtypefields for Livewire persistence; use dynamic repeater schema for new organismsOrganism: parameterizegetForm()withrequireUniqueNameandexcludedNamesfor report-change contextTest plan
php artisan test tests/Unit/ReportResourceMoleculeOptionsTest.php tests/Unit/OrganismReportChangeFormTest.phpRelated
Resolves
Closes #775
Closes #772