[Backend] Complete Party Invitation and Acceptance Flow#384
Open
zhero-o wants to merge 2 commits into
Open
Conversation
- POST /escrows/:id/parties/:partyId/accept — sets status to ACCEPTED, records respondedAt, logs PARTY_ACCEPTED event, notifies escrow creator - POST /escrows/:id/parties/:partyId/reject — sets status to REJECTED, auto-cancels escrow when a required party (buyer/seller) rejects, notifies escrow creator - GET /escrows/pending-invitations — lists escrows with PENDING party invitations for the authenticated user - fund() now gates on all buyer+seller parties having ACCEPTED status - PARTY_INVITED notification dispatched for each invited party on escrow creation - Add PARTY_INVITED, PARTY_ACCEPTED, PARTY_REJECTED to NotificationEventType enum - Add email templates for new notification events - Add respondedAt column to Party entity + migration - Import NotificationsModule into EscrowModule - Unit tests for accept, reject, getPendingInvitations, and fund gate Closes StayLitCodes#274
[Backend] Complete Party Invitation and Acceptance Flow
|
@zhero-o Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #274
Changes
New endpoints
POST/escrows/:id/parties/:partyId/acceptACCEPTED, recordsrespondedAt, logs event, notifies escrow creator.POST/escrows/:id/parties/:partyId/rejectGET/escrows/pending-invitationsPENDINGparty invitation.Rules enforced
party.userIdcan accept or reject their own invitationfund()now blocks with a 400 if any buyer or seller party hasn't acceptedPENDINGescrow automatically cancels itOther changes
PARTY_INVITED,PARTY_ACCEPTED,PARTY_REJECTEDadded toNotificationEventTyperespondedAt: Date | nullcolumn added toPartyentity1780300000000-AddRespondedAtToPartyadds the columnNotificationsModuleimported intoEscrowModuleTest plan
PARTY_INVITEDnotificationPOST /parties/:partyId/acceptas correct user → status becomesACCEPTEDPOST /parties/:partyId/acceptas wrong user → 403POST /parties/:partyId/accepttwice → 400POST /parties/:partyId/rejectby seller → escrow auto-cancels, creator notifiedGET /escrows/pending-invitations→ returns onlyPENDINGinvitations for current user