Skip to content

fix: update tldr cache zip location#1

Open
sebastiaanspeck wants to merge 1 commit into
StathisKap:mainfrom
sebastiaanspeck:patch-1
Open

fix: update tldr cache zip location#1
sebastiaanspeck wants to merge 1 commit into
StathisKap:mainfrom
sebastiaanspeck:patch-1

Conversation

@sebastiaanspeck
Copy link
Copy Markdown

@sebastiaanspeck sebastiaanspeck commented Apr 8, 2026

This PR updates the tldr cache location to use GitHub releases instead of the deprecated method of providing assets from the website repo.

See tldr-pages/tldr@v2.2 (release) and tldr-pages/tldr#20832 for more information.

Summary by CodeRabbit

  • Chores
    • Updated the tldr cache download source to use GitHub Releases instead of the legacy assets location.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

Updated the TLDR_DOWNLOAD_CACHE_LOCATION environment variable in the zsh configuration from a legacy GitHub Pages URL to the GitHub Releases latest download endpoint, changing the source URL for the tldr.zip asset download.

Changes

Cohort / File(s) Summary
Configuration Update
zsh/zshrc
Updated TLDR_DOWNLOAD_CACHE_LOCATION environment variable from https://tldr-pages.github.io/assets/tldr.zip to https://github.com/tldr-pages/tldr/releases/latest/download/tldr.zip.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a skip, a URL so neat,
The tldr cache now has a new beat,
From Pages old to Releases bright,
Our zsh config takes flight! 🚀
One line changed, the bunny's delight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the tldr cache zip download location from a legacy URL to the new GitHub Releases URL.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
zsh/zshrc (1)

161-161: Pin the TLDR archive to v2.2 instead of using latest.

At line 161, the latest/download endpoint currently resolves to v2.3, which conflicts with the PR's stated intent to use v2.2. Pinning to the explicit version ensures deterministic behavior and prevents silent version drift on future runs.

Suggested change
-export TLDR_DOWNLOAD_CACHE_LOCATION="https://github.com/tldr-pages/tldr/releases/latest/download/tldr.zip"
+export TLDR_DOWNLOAD_CACHE_LOCATION="https://github.com/tldr-pages/tldr/releases/download/v2.2/tldr.zip"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@zsh/zshrc` at line 161, The TLDR_DOWNLOAD_CACHE_LOCATION currently points at
the non-deterministic "latest/download" URL; update the environment variable
TLDR_DOWNLOAD_CACHE_LOCATION to reference the explicit v2.2 release archive
(replace the latest/download URL with the v2.2 release download URL) so the
script consistently uses tldr v2.2 and avoids silent version drift.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@zsh/zshrc`:
- Line 161: The TLDR_DOWNLOAD_CACHE_LOCATION currently points at the
non-deterministic "latest/download" URL; update the environment variable
TLDR_DOWNLOAD_CACHE_LOCATION to reference the explicit v2.2 release archive
(replace the latest/download URL with the v2.2 release download URL) so the
script consistently uses tldr v2.2 and avoids silent version drift.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b1ae1e0-92fa-4c05-9054-5c467e82a1c8

📥 Commits

Reviewing files that changed from the base of the PR and between 7e1e025 and 5067584.

📒 Files selected for processing (1)
  • zsh/zshrc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant