fix: update tldr cache zip location#1
Conversation
📝 WalkthroughWalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
zsh/zshrc (1)
161-161: Pin the TLDR archive to v2.2 instead of usinglatest.At line 161, the
latest/downloadendpoint currently resolves to v2.3, which conflicts with the PR's stated intent to use v2.2. Pinning to the explicit version ensures deterministic behavior and prevents silent version drift on future runs.Suggested change
-export TLDR_DOWNLOAD_CACHE_LOCATION="https://github.com/tldr-pages/tldr/releases/latest/download/tldr.zip" +export TLDR_DOWNLOAD_CACHE_LOCATION="https://github.com/tldr-pages/tldr/releases/download/v2.2/tldr.zip"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@zsh/zshrc` at line 161, The TLDR_DOWNLOAD_CACHE_LOCATION currently points at the non-deterministic "latest/download" URL; update the environment variable TLDR_DOWNLOAD_CACHE_LOCATION to reference the explicit v2.2 release archive (replace the latest/download URL with the v2.2 release download URL) so the script consistently uses tldr v2.2 and avoids silent version drift.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@zsh/zshrc`:
- Line 161: The TLDR_DOWNLOAD_CACHE_LOCATION currently points at the
non-deterministic "latest/download" URL; update the environment variable
TLDR_DOWNLOAD_CACHE_LOCATION to reference the explicit v2.2 release archive
(replace the latest/download URL with the v2.2 release download URL) so the
script consistently uses tldr v2.2 and avoids silent version drift.
This PR updates the tldr cache location to use GitHub releases instead of the deprecated method of providing assets from the website repo.
See tldr-pages/tldr@v2.2 (release) and tldr-pages/tldr#20832 for more information.
Summary by CodeRabbit