Refactor to route groups and server/client component split by bryceerobertson · Pull Request #294 · StampyAI/AISafety.com

bryceerobertson · 2026-03-05T02:32:51Z

Replaces part of #288.

Move all pages into (main) route group with shared Navigation + Footer layout
Add (standalone) route group for pages that need no nav/footer (used by poster map in a follow-up PR)
Split every resource page into a server component (data fetching) + client component (interactivity)
Add jobs date published display on cards
Fix communities map tooltip positioning (absolute → fixed)

Why: Server components fetch data on the server before sending the page to the browser — this means faster page loads, better SEO, and less JavaScript shipped to users. The route group structure lets different pages have different layouts (main site pages get nav + footer, while standalone pages like the poster map get nothing).

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel · 2026-03-05T02:32:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
ai-safety-com	Ready	Preview, Comment	Mar 10, 2026 2:32pm

…onal Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…factor

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add poster map page for printing physical posters

jakkdl

Massive code duplication - server pages vs API routes

Every page now has ~100 lines of nearly identical Airtable fetching code duplicated
between:

src/app/(main)/advisors/page.tsx (lines 27-89)

src/app/api/advisors/route.ts

And the same pattern for 8 other pages. This is ~800+ lines of duplicated Airtable logic.

that... kinda explains the size of the PR 🙃

Addresses PR #294 review feedback about ~800+ lines of duplicated Airtable fetching logic between server pages and API routes. Each resource's fetch function and type now live in a single shared module, imported by both the page and the API route. Also fixes 5 broken API routes that had placeholder TABLE_IDs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Move the ~40 lines of identical Airtable fetch boilerplate (credential check, URL construction, pagination loop, single retry) into a shared fetchAirtableRecords() function in src/lib/data/airtable.ts. Each data module now only contains its table/view IDs, type definitions, and transform logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

All 9 API routes incorrectly treated zero records as a server error. Empty results are legitimate (e.g. no published jobs), so always return 200 with the data array. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove lastModified (always null, never read by any page) from advisors, funding, media-channels, projects, and self-study. Remove lastModified and the !Date it closes field from jobs (misleadingly named, unused). Remove Short URL from map's fetch list (fetched but never mapped to output). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Resolve conflicts: - API routes: keep data module imports + jsonWithCache from main - Page files: keep (main)/ route group versions, delete old locations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

bryceerobertson · 2026-03-07T00:21:26Z

This comment was written by Claude Code, not Bryce.

These commits address @jakkdl's review feedback about the ~800+ lines of duplicated Airtable fetching logic across the 9 server pages and their corresponding API routes.

The core fix: shared data modules. A new fetchAirtableRecords() utility in src/lib/data/airtable.ts handles all the Airtable boilerplate (credentials, URL construction, pagination, retry). Each of the 9 data modules (advisors.ts, communities.ts, etc.) now only contains its table/view IDs, type definitions, and a transform function. Both the server pages and the API routes import from these same modules — no more duplication.

The API routes are now ~15 lines each (import, call, empty-result check, return), using jsonWithCache for cache headers.

Dead/misleading fields also removed: lastModified appeared in 6 interfaces but was always null and never read by any component. In jobs, it was misleadingly mapped to !Date it closes (also unused). Short URL was fetched from Airtable's map table but never mapped to output. All removed.

These tables are never empty, so zero results indicates a fetch failure (e.g. missing credentials, Airtable API error). The 500 is correct. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

bryceerobertson · 2026-03-07T00:36:38Z

@jakkdl hopefully this did it 🤞🏼 I used your method of getting Claude Code to check itself

Applied content updates from main (featured card changes, ContributeButtons props, funding newsletter link, media-channels card swap) to the new (main)/ route group locations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jakkdl · 2026-03-10T12:11:25Z

Did some more fundamental reviewing with Claude as to what this PR is trying to achieve, and if it's going at it in the right way. It's somewhat unclear if the server/client component split is worth it, I think we wouldn't have much issues on airtable's end with their API caching, and there's a decent complexity cost in terms of doubling the number of files that has to be maintained. But LLM's will probably be able to handle it fine enough.

The route groups seems less worth it when we only have a single weird page that doesn't want header/footer. I don't like that determining a big structural decision - I think we're better off with some small CSS magic or whatever on that page to hide the header/footer.

I'll push a commit with some changes~

Move all pages out of (main)/ and (standalone)/ route groups. This is a pure rename commit - no code changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Create LayoutShell client component to conditionally render nav/footer - poster-map now renders without nav/footer via pathname check - Fix type imports to use @/lib/data/* directly instead of API routes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- advisors: 80000_Hours_logo2.png → 80000-hours.png - advisors: dc409ec6a6a8a2083408f6dffc3f80c2.png → ai-safety-quest.png - funding: CG-LOGO.webp → coefficient-giving.webp - self-study: 2.png → alignment-forum.png - self-study: download-2.svg → blue-dot-impact.svg 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

jakkdl

I think we've collectively hammered Claude enough now that we can somewhat decently trust that this PR is good.

Refactor to route groups and server/client component split

a9f9145

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

bryceerobertson requested a review from melissasamworth March 5, 2026 02:32

vercel Bot had a problem deploying to Preview March 5, 2026 02:33 Failure

bryceerobertson mentioned this pull request Mar 5, 2026

Add poster map page for printing physical posters #295

Merged

Fix build: add datePublished to Job type, make FeaturedCard logo opti…

2cbc444

…onal Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel Bot deployed to Preview March 5, 2026 02:40 View deployment

bryceerobertson and others added 2 commits March 5, 2026 15:43

Merge remote-tracking branch 'origin/main' into bryce/route-groups-re…

fd10f7c

…factor

Add poster map page for printing physical posters

981e4e2

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

bryceerobertson mentioned this pull request Mar 5, 2026

Resource pages: server components, route groups, logos, and jobs improvements #288

Closed

vercel Bot deployed to Preview March 5, 2026 02:43 View deployment

Rename poster map URL from random string to /poster-map

b939d65

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

bryceerobertson requested a review from jakkdl March 6, 2026 02:47

Merge pull request #295 from StampyAI/bryce/poster-map

3e499f0

Add poster map page for printing physical posters

vercel Bot deployed to Preview March 6, 2026 02:48 View deployment

jakkdl requested changes Mar 6, 2026

View reviewed changes

bryceerobertson and others added 4 commits March 7, 2026 13:13

Fix API routes returning 500 for empty results

6a8dd6b

All 9 API routes incorrectly treated zero records as a server error. Empty results are legitimate (e.g. no published jobs), so always return 200 with the data array. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel Bot deployed to Preview March 7, 2026 00:13 View deployment

Merge origin/main into bryce/route-groups-refactor

d95ca21

Resolve conflicts: - API routes: keep data module imports + jsonWithCache from main - Page files: keep (main)/ route group versions, delete old locations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel Bot deployed to Preview March 7, 2026 00:19 View deployment

Restore empty-result 500 checks in API routes

946bbc3

These tables are never empty, so zero results indicates a fetch failure (e.g. missing credentials, Airtable API error). The 500 is correct. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel Bot deployed to Preview March 7, 2026 00:29 View deployment

bryceerobertson requested a review from jakkdl March 7, 2026 00:36

bryceerobertson removed the request for review from melissasamworth March 7, 2026 00:36

vercel Bot deployed to Preview March 7, 2026 22:44 View deployment

bryceerobertson force-pushed the bryce/route-groups-refactor branch from 8f1fe6e to 946bbc3 Compare March 7, 2026 23:57

vercel Bot deployed to Preview March 8, 2026 00:05 View deployment

jakkdl and others added 3 commits March 10, 2026 13:30

Revert route groups: move pages back to app root

bdec65e

Move all pages out of (main)/ and (standalone)/ route groups. This is a pure rename commit - no code changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

vercel Bot deployed to Preview March 10, 2026 14:32 View deployment

jakkdl approved these changes Mar 10, 2026

View reviewed changes

jakkdl mentioned this pull request Mar 10, 2026

community map doesn't reload on navigation #304

Closed

bryceerobertson merged commit f6431e8 into main Mar 11, 2026
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor to route groups and server/client component split#294

Refactor to route groups and server/client component split#294
bryceerobertson merged 16 commits intomainfrom
bryce/route-groups-refactor

bryceerobertson commented Mar 5, 2026

Uh oh!

vercel Bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

jakkdl left a comment

Uh oh!

bryceerobertson commented Mar 7, 2026 •

edited

Loading

Uh oh!

bryceerobertson commented Mar 7, 2026

Uh oh!

jakkdl commented Mar 10, 2026

Uh oh!

jakkdl left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bryceerobertson commented Mar 5, 2026

Uh oh!

vercel Bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakkdl left a comment

Choose a reason for hiding this comment

Uh oh!

bryceerobertson commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bryceerobertson commented Mar 7, 2026

Uh oh!

jakkdl commented Mar 10, 2026

Uh oh!

jakkdl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Mar 5, 2026 •

edited

Loading

bryceerobertson commented Mar 7, 2026 •

edited

Loading