Skip to content

fix: harden topology-satisfied handoff guidance v2#347

Merged
Stahl-G merged 1 commit into
mainfrom
codex/topology-satisfied-handoff-hardening-v2
Jul 2, 2026
Merged

fix: harden topology-satisfied handoff guidance v2#347
Stahl-G merged 1 commit into
mainfrom
codex/topology-satisfied-handoff-hardening-v2

Conversation

@Stahl-G

@Stahl-G Stahl-G commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • re-apply the reviewed topology-satisfied handoff hardening from fix: harden topology-satisfied handoff guidance #346 after the revert
  • add structured forbidden replay actions for topology-satisfied Screener stages in handoff protocol
  • make default topology handoff/runtime prompts explicitly forbid Screener delegation and stage-complete --stage screener
  • keep strict topology as the independent Screener path

Review Context

Validation

  • python3 -m pytest -q tests/test_start_commands.py tests/test_status_commands.py tests/test_hermes_adapter.py tests/test_subagent_first_contract.py tests/test_agent_config_generation.py
  • python3 scripts/generate_agent_configs.py --check
  • python3 scripts/check_product_baseline.py
  • python3 scripts/check_release_consistency.py --no-tag
  • git diff --check
  • non-editable install + scripts/ci/smoke_packaged_topology_handoff.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 983dd64456

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +955 to +958
"forbidden_replay_actions": [
f"delegate {stage_id}",
f"state stage-complete --stage {stage_id}",
],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restrict replay bans to satisfied target stages

When a workspace uses policy.role_topology=human_assisted, this helper also adds state stage-complete --stage analyst and --stage editor to the generated forbidden replay actions because it applies to every topology_satisfaction rule, not just Screener. That conflicts with the actual runtime path: configs/stage_specs.yaml marks analyst/editor as satisfied_by: writer, and the runtime advances human-assisted runs by completing stage-complete --stage analyst (see tests/test_runtime_state.py:3017). The resulting handoff tells operators not to run the transaction that freezes analyst_draft_snapshot and advances to auditor, so human-assisted runs can get stuck; please limit these forbidden actions to topology-satisfied downstream targets like Screener or derive them from the satisfier/trigger stage.

Useful? React with 👍 / 👎.

Co-authored-by: yihong guo <yihongguo@yihongdeMacBook-Pro-2.local>
@Stahl-G Stahl-G force-pushed the codex/topology-satisfied-handoff-hardening-v2 branch from 983dd64 to 6d7c4ba Compare July 2, 2026 07:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d7c4ba413

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +652 to +654
In default topology, do not delegate Screener and do not call
`state stage-complete --stage screener`; Scout writes `screened_candidates.json`
and the Screener stage is satisfied by topology after Scout completion.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Synchronize the checked-in Hermes skill

When adding this explicit default-topology replay ban to render_hermes_skill(), the repo-shipped Hermes skill assets were left unchanged: .agents/hermes-skills/multi-agent-brief-hermes/SKILL.md and its references/delegate-task-sequence.md still do not mention the new state stage-complete --stage screener prohibition. Source-clone Hermes users can load those checked-in skill files directly instead of reinstalling a freshly rendered skill, so they would continue to get the stale guidance this change is trying to harden; please update the checked-in Hermes skill/reference (and a contract test) as well.

Useful? React with 👍 / 👎.

@Stahl-G Stahl-G merged commit d719eb8 into main Jul 2, 2026
13 checks passed
@Stahl-G Stahl-G deleted the codex/topology-satisfied-handoff-hardening-v2 branch July 2, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant