Skip to content

feat: add quality panel real-run closeout guidance#340

Merged
Stahl-G merged 1 commit into
mainfrom
codex/quality-panel-real-run-closeout
Jul 2, 2026
Merged

feat: add quality panel real-run closeout guidance#340
Stahl-G merged 1 commit into
mainfrom
codex/quality-panel-real-run-closeout

Conversation

@Stahl-G

@Stahl-G Stahl-G commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a post-finalize quality_panel_closeout projection to finalize reports and status output
  • surface audit/delivery bundle separation in Quality Panel JSON, Markdown summary, and static HTML
  • keep Quality Panel as operator follow-up only: no auto-generation during finalize, no gate/delivery/release authority
  • update BriefLoop skill references and freshness guard, then sync Hermes plugin projection

Validation

  • python3 -m pytest -q tests/test_quality_panel.py tests/test_finalize_delivery_gate.py tests/test_status.py tests/test_report_bundles.py
  • python3 -m pytest -q tests/test_status.py tests/test_status_commands.py tests/test_contract_registry.py
  • python3 -m pytest -q
  • python3 scripts/check_release_consistency.py --no-tag
  • python3 scripts/check_version_consistency.py
  • PYTHONPATH=src python3 scripts/check_capabilities.py
  • python3 scripts/check_skill_contract.py
  • python3 scripts/check_briefloop_skill_freshness.py
  • python3 scripts/check_runtime_asset_parity.py
  • python3 scripts/generate_agent_configs.py --check
  • python3 scripts/sync_hermes_plugin_skills.py --check
  • python3 -m compileall -q src tests
  • git diff --check
  • direct import smoke for multi_agent_brief.product.quality_closeout
  • CLI smoke: quality summarize --workspace --json

@Stahl-G Stahl-G force-pushed the codex/quality-panel-real-run-closeout branch from a22354c to a282c6d Compare July 2, 2026 04:30
@Stahl-G Stahl-G marked this pull request as ready for review July 2, 2026 04:37
@Stahl-G Stahl-G merged commit 422ae90 into main Jul 2, 2026
13 checks passed
@Stahl-G Stahl-G deleted the codex/quality-panel-real-run-closeout branch July 2, 2026 04:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a282c6d241

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +143 to +147
closeout = quality_panel_closeout_projection(
workspace=ws,
finalize_report=finalize_report,
generated_by_quality_summarize=True,
artifact_registry=registry_payload,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid persisting pre-write closeout artifact state

When briefloop quality summarize is run for the first time, this call scans the workspace before write_quality_panel() has written quality_panel.json and before the summary/HTML writers run, so the persisted quality_panel.json records all three closeout artifacts in missing_artifacts. The command then creates those files, leaving the machine-readable audit/control artifact claiming its own siblings are missing even though they exist and may be bundled; generate the closeout presence fields after the writes or omit pre-write presence from the persisted panel.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant