feat: add quality panel real-run closeout guidance#340
Conversation
a22354c to
a282c6d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a282c6d241
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| closeout = quality_panel_closeout_projection( | ||
| workspace=ws, | ||
| finalize_report=finalize_report, | ||
| generated_by_quality_summarize=True, | ||
| artifact_registry=registry_payload, |
There was a problem hiding this comment.
Avoid persisting pre-write closeout artifact state
When briefloop quality summarize is run for the first time, this call scans the workspace before write_quality_panel() has written quality_panel.json and before the summary/HTML writers run, so the persisted quality_panel.json records all three closeout artifacts in missing_artifacts. The command then creates those files, leaving the machine-readable audit/control artifact claiming its own siblings are missing even though they exist and may be bundled; generate the closeout presence fields after the writes or omit pre-write presence from the persisted panel.
Useful? React with 👍 / 👎.
Summary
Validation