Mark cred retrieval error as recoverable error.#181
Open
StevenYCChou wants to merge 1 commit intomasterfrom
Open
Mark cred retrieval error as recoverable error.#181StevenYCChou wants to merge 1 commit intomasterfrom
StevenYCChou wants to merge 1 commit intomasterfrom
Conversation
The Client should not drop the sample because the credential cannot be retrieved. Once the credential is set correctly, client should try to resend the samples.
jkohen
reviewed
Sep 30, 2019
| return l | ||
| } | ||
|
|
||
| func TestStoreErrorHandlingOnCredentialRetrieval(t *testing.T) { |
Contributor
There was a problem hiding this comment.
How does this test verify credential retrieval? Please document that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Client should not drop the sample because the credential cannot be
retrieved. Once the credential is set correctly, client should try to
resend the samples.