Added CLI flag to onlyUpdate shortcuts#1674
Merged
anaisbetts merged 1 commit intoSquirrel:developfrom Oct 31, 2020
Merged
Conversation
By default, running withcreateShortcut will create shortcuts in each specified location. If the user has deleted one of these shortcuts, it should optionally not be recreated. `CreateShortcutsForExecutable` has an option to "onlyUpdate" shortcuts (i.e. skipping if the shortcut does not already exist, this change esposes this option to the CLI as a flag.
|
Would also like to see this exposed, thanks for making a PR for this! |
Contributor
|
👍 , thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, running with
--createShortcutwill create shortcuts in each specified location. Running it again after a user has explicitly deleted a shortcut will result in the shortcut being re-created. If the user has deleted one of these shortcuts, Squirrel should be able to optionally not recreate them in order to respect the user's decision to delete. Because the calculation of shortcut paths and details is handled within Squirrel, this should be handled by Squirrel itself rather than by Squirrel apps.CreateShortcutsForExecutablehas an option to "onlyUpdate" shortcuts (i.e. skipping if the shortcut does not already exist), this change exposes this option to the CLI as a flag.This is intended to resurrect #1368 which has gone out of date.
This impacts the following issues: #1050, #831 and potentially enables a solution for multiple other shortcut related issues (see references in linked issues).