Fix #1283 (Spaces in filename cause ReleaseEntry Regex to fail)#1401
Fix #1283 (Spaces in filename cause ReleaseEntry Regex to fail)#1401cbenard wants to merge 1 commit intoSquirrel:masterfrom
Conversation
|
There are extensive unit tests for this function...could you figure out a new one that fails without the fix? |
|
@JohnThomson, I didn't have a dev env set up for this. I went ahead and cloned in the NuGet submodule and opened it in VS2017. Even in master, there are a ton of failing tests for me. Also, I looked at the tests for I don't want to try to add files with spaces to the repo and given that there are failing tests already, this is beyond the time I have to spend on it. I'm confident in the RegEx that we worked on together. If you'd like to mess with the tests, please do your own PR. If the tests were all green already, I would have likely proceeded. |
|
I think I've seen problems running all the tests, too. But there's a suite of tests, the second last entry in your screen shot, for ReleaseEntryTests, and many of them test this specific method, passing it a string (the file contents). So I believe it should be fairly easy to add a test that requires the fix without adding any files. |

Regex change allows spaces in the filename for while requiring at least one non-space character to fix #1283. Worked with @JohnThomson to refined the regex in the issue comments.