Add formal trait trade-off registry#4
Open
Spbd1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
confidence_leveltag.Description
TraitEffectdataclass andTRAIT_TRADEOFFSregistry inpishiegen/fitness/tradeoffs.pywith the 12 required traits, each listingpositive_effects,negative_effects,affected_contexts,biological_rationale, andconfidence_level(high|moderate|speculative).pishiegen.fitnessby updatingpishiegen/fitness/__init__.pyto includeTRAIT_TRADEOFFS,TraitEffect, andall_trait_effects.docs/trait_tradeoff_matrix.mddocumenting rules, the rationale summary for each trait, and the implementation link.tests/test_trait_tradeoffs.pythat assert the registry contains the required keys, every trait has at least one benefit and one cost, effect directions are explicit, and metadata fields (affected_contexts,biological_rationale,confidence_level) are present.Testing
python -m pytest, all tests passed (20 passed), includingtests/test_trait_tradeoffs.pywhich verifies the one-benefit/one-cost rule and metadata.python -m compileall pishiegento verify module byte-compilation succeeded.Codex Task