Use pnpm db:deploy in Compose and tighten export sanitizer#16
Open
Spbd1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
prisma migrate deployviapnpm db:deploywhile keepingpnpm db:migratefor local interactive development.ipinsidedescription) and risked removing safe config keys; it needs exact/boundary-aware detection instead of a single regex.Description
migrateservice command frompnpm db:migratetopnpm db:deployindocker-compose.ymland clarified the Docker section inREADME.mdto explain when to usepnpm db:deployvspnpm db:migrate.SENSITIVE_CONFIG_KEY_PATTERNregex inapps/web/lib/services/researchExport.tswith a boundary-aware approach usingisSensitiveConfigKey, helperconfigKeyTerms, a set of sensitive terms, and aliases so only exact/bounded sensitive keys are removed.sanitizeForExportto useisSensitiveConfigKey(key)for filtering object keys.apps/web/lib/services/researchExport.test.tswith cases verifying that sensitive keys (password,token,secret,auth,ip,ipAddress, etc.) are removed and that safe keys containing those substrings (e.g.,description,publicGoodMultiplier,multiplier,participationLabel) are preserved.Testing
git diff --check, which produced no whitespace errors and succeeded.apps/web/lib/services/researchExport.test.tscovering both removal of sensitive values and preservation of safe keys, but running the test suite was blocked because development dependencies are not installed in the environment (vitest: not found), so tests were not executed here.Codex Task