Harden reproducibility, security, and deployment#14
Open
Spbd1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
APP_SECRETand verify before user lookup, and add theSecureattribute in production (apps/web/lib/api/auth.ts).createRandom) usingserver.randomSeedand join index (apps/web/lib/services/game.ts).uncertaintyRuleChangeRoundsanduncertaintyPossibleEventstoEngineConfig, loading them from server overrides, passing them intoapplyRuleChangeIfNeeded, and restricting rule changes to uncertain servers and to configured rounds/events (packages/engine/src/types.ts,packages/engine/src/serverSimulator.ts,packages/engine/src/roundResolver.ts,apps/web/lib/services/game.ts).server_configs.csvto the research export containing engine overrides and versionedServerConfigrows so treatment/tuning provenance and seeds are preserved (apps/web/lib/services/researchExport.ts).apps/web/app/api/servers/[serverId]/final-summary/route.ts,apps/web/app/game/[serverId]/final/page.tsx).prisma migrate deploy(packages/db/prisma/migrations/20260510120000_initial_schema/migration.sql,packages/db/package.json,docs/deployment.md).packages/engine/src/index.test.ts).Testing
tsc --noEmit -p packages/engine/tsconfig.build.jsonran and passed for the engine build.python3 -m json.tool package.jsonandpython3 -m json.tool packages/db/package.jsonandpython3 -m json.tool configs/*.jsonpassed.pnpm installfailed in this environment due to a registry403fetching@types/node, so workspace dependencies were not installed and full test runs could not execute.pnpm --filter @parcel-society/engine test) did not run becausevitestwas unavailable in the environment (dependency install failed).tsc --noEmit -p apps/web/tsconfig.json) could not complete here because Next/React workspace dependencies were not installed.Codex Task