Harden Parcel Society MVP for deployment#10
Open
Spbd1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
.strict()and added amax(3)limit on submitted decisions, plus explicit JSON/validation error mapping inapps/web/lib/api/schemas.tsandapps/web/lib/api/responses.ts.requireSuperAdminAuth, hardened participant checks, prevented duplicate joins, disallowed actions after exit, enforced exit-as-final-action and inactive-round protection, and limited exposed participant state (removed wealth/reputation for other players) inapps/web/lib/services/game.ts,apps/web/lib/api/auth.ts, andapps/web/app/api/servers/[serverId]/state/route.ts.rateLimithelper and applied it to admin login, join, decision submission, and export endpoints, and addedrecordAdminActionto record admin actions (create/update/start/generate/resolve/archive/export) into theauditLogmodel viaapps/web/lib/api/audit.tsand wired calls in admin routes.ApiClientErrorinapps/web/app/components/api.ts.apps/web/lib/api/hardening.test.ts,apps/web/lib/api/auth.test.ts,packages/engine/src/hardening.test.ts) and added a GitHub Actions CI workflow that runs install, Prisma client generation, typecheck, lint, test, and build (.github/workflows/ci.yml).apps/web/Dockerfileto include workspace package manifests and to run Prisma client generation before the Next build, and expandednext.config.tsto transpile workspace packages needed in the standalone build.Testing
git diff --checkwas run and passed locally.vitest) but executing the workspace test/typecheck/lint/build pipelines was blocked becausepnpm installfailed in this environment due to a registry 403 when fetching@eslint/js, causing missing dev/runtime dependencies and preventingtsc,eslint,vitest, and Prisma client generation from running successfully.pnpm typecheck,pnpm lint,pnpm test, andpnpm buildwere therefore attempted but could not complete due to the failed dependency install (missing@prisma/client,vitest,@eslint/js, etc.).docker buildwas attempted but could not be executed in this environment because Docker is not available; the Dockerfile was updated to run a production-safe build including Prisma generation and Next standalone output.Codex Task