Enable registration api#3
Open
Rinary1 wants to merge 5 commits into
Open
Conversation
8391fa0 to
f7616c9
Compare
| } | ||
|
|
||
| // Console.WriteLine(Request.Headers["SS14-Launcher-Fingerprint"]); | ||
| // Console.WriteLine(Request.Headers["User-Agent"]); |
There was a problem hiding this comment.
// Console.WriteLine(Request.Headers["SS14-Launcher-Fingerprint"]);
// Console.WriteLine(Request.Headers["User-Agent"]);
Why was this removed?
Author
There was a problem hiding this comment.
// Console.WriteLine(Request.Headers["SS14-Launcher-Fingerprint"]); // Console.WriteLine(Request.Headers["User-Agent"]);Why was this removed?
I'm not sure if this is that important, for me it looks like dead code. If anyone needs to debug it, they can just add it locally, right?
This reverts commit 5c901d8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables registration api with security fixes, summary:
Makes some "out of topic" changes so as not to undermine "general equality":
(The same approach as with the Security Notice; its purpose is simply to make the response times for successful and unsuccessful requests roughly the same, because before, unsuccessful response was faster)
Create conflicts with #2.