This repository was archived by the owner on Jun 28, 2026. It is now read-only.
Cleanup IManifoldManager and shape methods#43
Open
metalgearsloth wants to merge 4 commits into
Open
Conversation
Moved radius setters into a standard area to share code. Same with the IPhysShape methods so we can duplicate less.
|
Shipfork enjoyers watching with great interest. |
DrSmugleaf
approved these changes
Jun 23, 2026
DrSmugleaf
reviewed
Jun 23, 2026
DrSmugleaf
left a comment
Collaborator
There was a problem hiding this comment.
Failed TestSpawnTraversal [237 ms]
Error Message:
Robust.Shared.IoC.Exceptions.UnregisteredDependencyException : Robust.Shared.Physics.Systems.FixturesChangeSystem requested unregistered type with a dependency field: Robust.Shared.Physics.Systems.SharedPhysicsSystem
# Conflicts: # RELEASE-NOTES.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved radius setters into a standard area to share code.
Same with the IPhysShape methods so we can duplicate less.
IManifoldManager got moved to sharedphysicssystem so content can use it if it wants.