Skip to content
This repository was archived by the owner on Jun 28, 2026. It is now read-only.

Cleanup IManifoldManager and shape methods#43

Open
metalgearsloth wants to merge 4 commits into
Space-Wizards-Federation:masterfrom
metalgearsloth:2026-06-19-physics
Open

Cleanup IManifoldManager and shape methods#43
metalgearsloth wants to merge 4 commits into
Space-Wizards-Federation:masterfrom
metalgearsloth:2026-06-19-physics

Conversation

@metalgearsloth

@metalgearsloth metalgearsloth commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Moved radius setters into a standard area to share code.
Same with the IPhysShape methods so we can duplicate less.
IManifoldManager got moved to sharedphysicssystem so content can use it if it wants.

  1. ChildCount is liable to get removed if I ever finish v3 port and I hate seeing it on the objects. Also makes it easier to do future updates having the 1 spot and not across a bunch of areas.
  2. Radius validation was inconsistent.
  3. ShapeType was a C++ism that wasn't needed.
  4. IManifoldManager can be useful.

Moved radius setters into a standard area to share code.
Same with the IPhysShape methods so we can duplicate less.
@Velken Velken added the enhancement New feature or request label Jun 19, 2026
@rebaserHEAD

Copy link
Copy Markdown

Shipfork enjoyers watching with great interest.

@DrSmugleaf DrSmugleaf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  Failed TestSpawnTraversal [237 ms]
  Error Message:
   Robust.Shared.IoC.Exceptions.UnregisteredDependencyException : Robust.Shared.Physics.Systems.FixturesChangeSystem requested unregistered type with a dependency field: Robust.Shared.Physics.Systems.SharedPhysicsSystem

From https://github.com/Space-Wizards-Federation/RobustToolbox/actions/runs/27812117239/job/82304667588?pr=43

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants