Skip to content
This repository was archived by the owner on Jun 28, 2026. It is now read-only.

Upgrade to newer XamlX#3

Open
sowelipililimute wants to merge 8 commits into
Space-Wizards-Federation:masterfrom
sowelipililimute:work/jblackquill/demo-xamlx
Open

Upgrade to newer XamlX#3
sowelipililimute wants to merge 8 commits into
Space-Wizards-Federation:masterfrom
sowelipililimute:work/jblackquill/demo-xamlx

Conversation

@sowelipililimute

Copy link
Copy Markdown
Contributor

Requires space-wizards/space-station-14#43866

This updates our XamlX to a newer version that lets us more easily support features such as templated controls and data binding without having to try and backport verifiable code fixes to our 5-year-old fork of XamlX.

Breaking Changes

The syntax for multiple style classes has changed from:

<Control.StyleClasses>
  <system:String>Hello</system:String>
  <system:String>World</system:String>
</Control.StyleClasses>

to

<Control StyleClasses="Hello World" />

@Fildrance Fildrance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New declaration style would be great improvement, very nice.

Having mandatory change to new style is meh to me, perosnally - i have hard time imagining where it would fit (maybe situation with extra-long style name, or having to combine 10+ styles? well person building it would be failing at design at that point i think).

Having nullable suppression in parts that are not 1-to-1 copes from xamlx could worth have proper null handling, but i don't exepct it to matter too much.

Comment thread Robust.Client.NameGenerator/RoslynTypeSystem.cs Outdated
Comment thread Robust.Client.NameGenerator/XamlUiPartialClassGenerator.cs Outdated
Comment thread Robust.Client.NameGenerator/XamlUiPartialClassGenerator.cs Outdated
Comment thread Robust.Client.NameGenerator/XamlUiPartialClassGenerator.cs
Comment thread Robust.Client.NameGenerator/XamlUiPartialClassGenerator.cs Outdated
Comment thread Robust.Xaml/XamlAotCompiler.cs Outdated
Comment thread Robust.Xaml/XamlJitCompiler.cs Outdated
Comment thread Robust.Xaml/XamlJitCompiler.cs Outdated
Comment thread Robust.Xaml/XamlJitCompiler.cs Outdated
Comment thread Robust.Client/UserInterface/Controls/Button.cs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants