This repository was archived by the owner on Jun 28, 2026. It is now read-only.
Fix Robust.Benchmarks failing to build its runner, again#146
Open
ArtisticRoomba wants to merge 1 commit into
Open
Fix Robust.Benchmarks failing to build its runner, again#146ArtisticRoomba wants to merge 1 commit into
Robust.Benchmarks failing to build its runner, again#146ArtisticRoomba wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back at it again at Krispy Kreme.
Fixes #130
Similar to the last time this happened (technically my last PR that fixed this was only a partial fix),
BenchmarkDotNetcannot build its autogenerated runner for some benchmarks due to failing to reference transitive dependencies. This is because we intentionally don't expose them so none of them can accidentally leak to Content.Because of this we special-case
BenchmarkDotNet.Autogeneratedand just disable transitive project references. From my admittedly limited understanding of MsBuild the possibility of someone naming their projectBenchmarkDotNet.Autogeneratedto get past the check isn't a concern as the condition only matters in aRobustToolboxcontext.