This repository was archived by the owner on Jun 28, 2026. It is now read-only.
Expose OpenAL doppler factor#140
Open
metalgearsloth wants to merge 2 commits into
Open
Conversation
Contributor
|
Is it worth exposing speed-of-sound if we have it in our bindings? See: https://www.openal.org/documentation/OpenAL_Programmers_Guide.pdf, bottom of page 14 and page 15. |
Contributor
Author
There's a lot of stuff still to be implemented from openAL, yeah. |
DrSmugleaf
reviewed
Jun 23, 2026
Comment on lines
+1306
to
+1307
| public static readonly CVarDef<float> AudioDopplerFactor = | ||
| CVarDef.Create("audio.doppler_factor", 1f, CVar.SERVER | CVar.REPLICATED); |
Collaborator
There was a problem hiding this comment.
Is it worth making this a SERVER CVar? With master gain, RMC had to do some workarounds to make a deafness effect work since it's set in many places
Granted I don't really see an usecase in setting this in code or per-client, but still
Contributor
Author
There was a problem hiding this comment.
Can make it client and add a setter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title.