Skip to content

workstation-v0 aggregate shortcut and dock polish signals #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdheller merged 2 commits into from
May 2, 2026
Merged

workstation-v0 aggregate shortcut and dock polish signals #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f7a9b2
workstation-v0: aggregate shortcut and dock polish signals
mdheller May 2, 2026
d7772b4
ci(workstation): assert aggregate shortcut and dock polish signals
mdheller May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 38 additions & 3 deletions .github/workflows/workstation-polish-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:
- 'profiles/linux-dev/workstation-v0/bin/check-workstation-polish.sh'
- 'profiles/linux-dev/workstation-v0/bin/check-mac-polish.sh'
- 'profiles/linux-dev/workstation-v0/bin/check-keyboard-policy.sh'
- 'profiles/linux-dev/workstation-v0/bin/check-shortcut-map-contract.sh'
- 'profiles/linux-dev/workstation-v0/bin/check-gnome-dock-extension.sh'
- '.github/workflows/workstation-polish-validation.yml'
push:
branches:
Expand All @@ -14,6 +16,8 @@ on:
- 'profiles/linux-dev/workstation-v0/bin/check-workstation-polish.sh'
- 'profiles/linux-dev/workstation-v0/bin/check-mac-polish.sh'
- 'profiles/linux-dev/workstation-v0/bin/check-keyboard-policy.sh'
- 'profiles/linux-dev/workstation-v0/bin/check-shortcut-map-contract.sh'
- 'profiles/linux-dev/workstation-v0/bin/check-gnome-dock-extension.sh'
- '.github/workflows/workstation-polish-validation.yml'

jobs:
Expand All @@ -23,14 +27,16 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- name: Syntax check aggregate helper
- name: Syntax check aggregate helper and source helpers
run: |
set -euo pipefail
bash -n profiles/linux-dev/workstation-v0/bin/check-workstation-polish.sh
bash -n profiles/linux-dev/workstation-v0/bin/check-mac-polish.sh
bash -n profiles/linux-dev/workstation-v0/bin/check-keyboard-policy.sh
bash -n profiles/linux-dev/workstation-v0/bin/check-shortcut-map-contract.sh
bash -n profiles/linux-dev/workstation-v0/bin/check-gnome-dock-extension.sh

- name: Smoke: aggregate helper prefixes Mac and keyboard policy outputs
- name: Smoke: aggregate helper prefixes all workstation polish outputs
run: |
set -euo pipefail
helper='profiles/linux-dev/workstation-v0/bin/check-workstation-polish.sh'
Expand All @@ -53,7 +59,26 @@ jobs:
#!/usr/bin/env bash
exit 0
EOF
chmod +x "$stub_bin/gnome-screenshot" "$stub_bin/sushi" "$stub_bin/mac-screenshot.sh" "$stub_bin/input-remapper-control"
cat > "$stub_bin/gnome-extensions" <<'EOF'
#!/usr/bin/env bash
set -euo pipefail
if [ "${1:-}" = list ]; then
printf 'dash-to-dock@micxgx.gmail.com\n'
printf 'appindicatorsupport@rgcjonas.gmail.com\n'
exit 0
fi
exit 2
EOF
cat > "$stub_bin/gsettings" <<'EOF'
#!/usr/bin/env bash
set -euo pipefail
if [ "${1:-}" = get ] && [ "${2:-}" = org.gnome.shell ] && [ "${3:-}" = favorite-apps ]; then
printf "['org.gnome.Nautilus.desktop', 'org.gnome.Terminal.desktop']\n"
exit 0
fi
exit 2
EOF
chmod +x "$stub_bin/gnome-screenshot" "$stub_bin/sushi" "$stub_bin/mac-screenshot.sh" "$stub_bin/input-remapper-control" "$stub_bin/gnome-extensions" "$stub_bin/gsettings"

out=$(HOME="$tmp_home" XDG_CONFIG_HOME="$tmp_home/.config" PATH="$stub_bin:$PATH" bash "$helper")
grep -F 'mac_polish.helper=present' <<<"$out" >/dev/null
Expand All @@ -65,3 +90,13 @@ jobs:
grep -F 'keyboard_policy.primary_backend=input-remapper' <<<"$out" >/dev/null
grep -F 'keyboard_policy.selected_backend_available=present' <<<"$out" >/dev/null
grep -F 'keyboard_policy.policy_ok=yes' <<<"$out" >/dev/null
grep -F 'shortcut_map.helper=present' <<<"$out" >/dev/null
grep -F 'shortcut_map.shortcut_map=present' <<<"$out" >/dev/null
grep -F 'shortcut_map.active_palette=present' <<<"$out" >/dev/null
grep -F 'shortcut_map.active_screenshot_screen=present' <<<"$out" >/dev/null
grep -F 'shortcut_map.non_goal_marker=present' <<<"$out" >/dev/null
grep -F 'gnome_dock.helper=present' <<<"$out" >/dev/null
grep -F 'gnome_dock.gnome_extensions=present' <<<"$out" >/dev/null
grep -F 'gnome_dock.dash_to_dock=present' <<<"$out" >/dev/null
grep -F 'gnome_dock.appindicator=present' <<<"$out" >/dev/null
grep -F 'gnome_dock.gnome_dock_extension_lane_ok=yes' <<<"$out" >/dev/null
4 changes: 3 additions & 1 deletion profiles/linux-dev/workstation-v0/bin/check-workstation-polish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -euo pipefail

# Aggregate workstation polish validation helper.
# Consumes small key=value helpers and emits section-prefixed key=value lines.
# This is intentionally shell-only so it can feed CI, doctor, and status later.
# This is intentionally shell-only so it can feed CI, doctor, and status.

profile_dir(){
cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd
Expand Down Expand Up @@ -31,6 +31,8 @@ main(){
printf 'profile_dir=%s\n' "$pdir"
emit_section mac_polish "$pdir/bin/check-mac-polish.sh"
emit_section keyboard_policy "$pdir/bin/check-keyboard-policy.sh"
emit_section shortcut_map "$pdir/bin/check-shortcut-map-contract.sh"
emit_section gnome_dock "$pdir/bin/check-gnome-dock-extension.sh"
}

main "$@"