Normalize markdown and richtext editor field handling#687
Open
bobbwal wants to merge 1 commit intoSonicJs-Org:mainfrom
Open
Normalize markdown and richtext editor field handling#687bobbwal wants to merge 1 commit intoSonicJs-Org:mainfrom
bobbwal wants to merge 1 commit intoSonicJs-Org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalizes editor field handling so
markdownbecomes the canonical markdown field type, whilemdxeditorandeasymderemain supported aliases. This also fixes editor provider scoping, schema-backed field resolution, and a few related admin form regressions uncovered during review.Fixes #569
Fixes #674
Supersedes PR #570
Changes
markdownthe canonical markdown field type in types, admin collection editing, and docsmdxeditorandeasymdeworking as compatibility aliasesrichtextas the TinyMCE-backed default rich text typetinymceback torichtextin the admin collection editor flow so schemas round-trip safelyformat: 'richtext'renders via the richtext path instead of a plain text inputselectand keep their optionsTesting
npm run type-checknpm test --workspace=packages/core -- dynamic-field-extended.test.ts admin-content-field-types.test.ts admin-collections-field-types.test.tsBASE_URL=http://localhost:8787 npx playwright test tests/e2e/60-markdown-field-type.spec.ts --config tests/ playwright.config.tsBASE_URL=http://localhost:8787 npx playwright test tests/e2e/61-richtext-field-type.spec.ts --config tests/ playwright.config.tsUnit Tests
E2E Tests
Screenshots/Videos
Checklist