Potential fix for code scanning alert no. 32: XML external entity expansion#13
Draft
Potential fix for code scanning alert no. 32: XML external entity expansion#13
Conversation
…ansion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/SolidifyDemo/ghas-vulnerable-python-template/security/code-scanning/32
In general, to fix XXE vulnerabilities you must ensure that XML parsers used on untrusted input cannot resolve external entities. With Python’s SAX/DOM stack, this means disabling the external entity features on the parser (or using a hardened library like
defusedxml) and avoiding any API that performs arbitrary entity expansion.For this specific function, the safest minimal fix while keeping existing behavior (extracting the text of the
<text>element and storing it in the database) is:feature_external_ges; instead, explicitly disable it.doc.expandNode(node), which attempts to expand entity references.<text>element, but without expanding entities. Since this view appears to be a lab, we keep the general structure and return value intact.Concretely, in
introduction/views.py:xxe_parse, changeparser.setFeature(feature_external_ges, True)toparser.setFeature(feature_external_ges, False).doc.expandNode(node)and the manualtoxml()plus substring slicing. Instead, build the element’s text by joining its text node children.These changes require no new imports and keep the stored comment equal to the literal text content between
<text>and</text>in the user’s XML.Suggested fixes powered by Copilot Autofix. Review carefully before merging.