Fix Inkplate 6 Color battery reading#21
Open
zachstence wants to merge 2 commits intoSolderedElectronics:devfrom
Open
Fix Inkplate 6 Color battery reading#21zachstence wants to merge 2 commits intoSolderedElectronics:devfrom
zachstence wants to merge 2 commits intoSolderedElectronics:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected behavior:
Inkplate.readBatteryshould read the battery level of an Inkplate 6 ColorActual behavior:
The following error occurs:
Problem:
The GPIO pins were not being correctly initialized for reading the battery.
The
readBatteryfunction was not correctly using the PCAL6416A classSolution:
Initialize GPIO pins for reading battery
Update
readBatteryfunction to properly read the voltageAdd a comment explaining the battery voltage calculation equation