Fix urlExists to use HTTPS for HTTPS URLs and make feedsession.json o…#66
Open
Fix urlExists to use HTTPS for HTTPS URLs and make feedsession.json o…#66
Conversation
…ptional in feed download The urlExists function used http for all requests, causing URL validation to silently fail on HTTPS URLs (like GitHub raw content). The feed download also hard-exited when feedsession.json was missing, even though it's not present in all community feeds.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes URL validation for HTTPS endpoints in urlExists() and adjusts feed archival/download logic to treat feedsession.json as optional so community feeds without it can still be exported.
Changes:
- Update
urlExists()to choosehttpsvshttptransport based on the URL protocol. - Update feed archive download flow to attempt loading
feedsession.jsonand skip it if missing (instead of hard-exiting).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/utils/config.ts |
Switch urlExists() to use https for https: URLs. |
src/lib/feed-archive.ts |
Make feedsession.json optional during feed export by wrapping load/write in try/catch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+173
to
+174
| data = gitFeed ? await loadGitFeedSessionFile(feedName, defaultFeedSessionFile) : loadLocalFeedFile(feedName, defaultFeedSessionFile); | ||
| writeJsonFile(`${zipPath}/${defaultFeedSessionFile}`, data); |
Comment on lines
+914
to
915
| const { host, pathname, protocol } = valid_url | ||
| const opt = { method: 'HEAD', host, path: pathname } |
Comment on lines
+158
to
+159
| data = gitFeed ? await loadGitFeedSessionFile(feedName, defaultFeedSessionFile) : loadLocalFeedFile(feedName, defaultFeedSessionFile); | ||
| writeJsonFile(`${zipPath}/${defaultFeedSessionFile}`, data); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix urlExists to use HTTPS for HTTPS URLs and make feedsession.json optional in feed download
The urlExists function used http for all requests, causing URL validation to silently fail on HTTPS URLs (like GitHub raw content). The feed download also hard-exited when feedsession.json was missing, even though it's not present in all community feeds.