verify: drop dangling pathB_stream fixture entry + fail loud on missing files#75
Merged
Merged
Conversation
…ng files
verify_fixtures_strict.py's `sets` list referenced
("vectors_hex_pathB_stream.txt", ...), but that fixture NEVER existed (absent
from all of git history) and is not a real contract: Path-B (THEORY.md §5) is a
ternary payload-encoding axis, not a streaming lane — streaming is covered by the
avro stream fixtures (avrochunk/avronested). There is no in-repo generator, so
manufacturing self-consistent-but-meaningless frames would only fake coverage.
`verify_file` silently `return`ed on the missing file, so this lane was never
verified and the gap was invisible.
- Remove the stale pathB_stream entry (reflects reality: no such lane).
- Make verify_file FAIL (exit 2) instead of silently skipping when a listed
fixture/nonces file is missing, so future dangling references surface in CI
immediately rather than becoming silent no-ops.
All remaining lanes have real files; `make verify` stays green (exit 0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tools/verify_fixtures_strict.py'ssetslist referenced("vectors_hex_pathB_stream.txt", "….nonces"), butfixtures/vectors_hex_pathB_stream.txtdoes not exist andverify_file()silentlyreturned on the missing path — so that lane was never verified and the gap was invisible (no CI failure).Decision: remove the entry (option b), not generate vectors (option a)
Evidence the lane isn't real:
git log --allempty); thesetsentry has been a dangling no-op since the repo was assembled.pathB_streamanywhere is that onesetsline. Path-B (docs/THEORY.md§5) is a ternary payload-encoding axis compatible with the same envelope/AEAD; streaming is a separate axis already covered byvectors_hex_stream_avrochunk/avronested.Changes
pathB_streamsetsentry.verify_filenow fails (exit 2) with a clear message when a listed fixture/nonces file is missing, instead of silently skipping — so future dangling references surface in CI immediately.Verification
verify_fixtures_strict.py→[OK] All fixture AEAD tags verified, exit 0.make verify→ exit 0 (all lanes real).