fix(fixtures): recover corrupt lane1_submit_request frame (green make verify)#74
Merged
Conversation
…bble) `make verify` (CI `ci` job) was red on main: verify_fixtures_strict.py aborted with "non-hexadecimal number found" because the lane1_submit_request frame in fixtures/vectors_hex_prophet_lane1.txt was odd-length (1561 hex chars) — a single hex nibble was dropped when the vector was first committed (bee3137), so this job has been red since. The other five lane1 frames verify cleanly. The frame carries a BLAKE2b-MAC AEAD tag, which acts as a strong recovery oracle: brute-forcing a single-nibble insertion at every position yields exactly one reconstruction whose recomputed blake2b(aad, key=0) equals its embedded tag — a dropped 'f' at hex position 1035. That uniqueness (false-match ~2^-128) makes this a verified recovery of the original frame, not a fabricated value. The frame now passes the same AEAD check as lane1 frames 2-6. make verify green end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI
cijob (make verify) red on main:tools/verify_fixtures_strict.pyaborted withValueError: non-hexadecimal number foundat thefixturesstep. Cause: thelane1_submit_requestframe infixtures/vectors_hex_prophet_lane1.txtwas odd-length (1561 hex chars) — a single nibble was dropped when the vector was first committed (bee3137), so this job has been red since. The other 5 lane1 frames verify cleanly.Recovery (verified, not fabricated)
The frame carries a BLAKE2b-MAC AEAD tag → a strong recovery oracle. Brute-forcing a single-nibble insertion at every position (16 × 1562 candidates) yields exactly one reconstruction whose recomputed
blake2b(aad, key=0)equals its embedded tag: a droppedfat hex position 1035. Uniqueness (false match ≈ 2⁻¹²⁸) makes this the original frame. It now passes the same AEAD check as lane1 frames 2–6.Verification
make verify→ exit 0: rust-test, go-test, fixtures (all AEAD tags OK), aux-shape, avro-lom-diagrams all green.Note (not addressed here)
verify_fixtures_strict.py'ssetslist referencesvectors_hex_pathB_stream.txt, which does not exist —verify_filesilently returns early, so that lane is currently unverified. Flagging separately; not a CI failure.