fix(go): real module path for the v1 port (drop example/ placeholder)#71
Merged
Conversation
go/tritrpcv1 declared 'module github.com/example/tritrpcv1' — an unresolvable scaffold placeholder, so the module could not be 'go get'-able and imports referenced a fake org. Point it at the real path github.com/SocioProphet/TriTRPC/go/tritrpcv1 (go.mod + the cmd/trpc importer). Keeps the v1 suffix deliberately: the stable line is named consistently across languages (rust/tritrpc_v1, reference/tritrpc_v1.py), and that 1:1 cross-language anchor is the point of a reference implementation. vNext gets its own sibling module (go/tritrpcvnext) when the Go port lands — mirroring reference/experimental/..._v4 — rather than de-versioning v1 or using Go semantic-import /v2 suffixes. Effectively non-breaking: the example/ placeholder is unresolvable, so no external importer exists. Verified: go build ./..., go vet ./..., go test ./... all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
go/tritrpcv1/go.moddeclaredmodule github.com/example/tritrpcv1— a leftover scaffold placeholder. That makes the module un-go get-able and its imports reference a fake org. This points it at the real pathgithub.com/SocioProphet/TriTRPC/go/tritrpcv1(go.mod + thecmd/trpcimporter).Why keep
v1(not de-version, not Go/v2SIV)The stable line is named consistently across languages —
rust/tritrpc_v1,go/tritrpcv1,reference/tritrpc_v1.py— and that auditable 1:1 cross-language anchor is the whole point of a reference implementation. So thev1stays. When the Go vNext port lands it gets its own sibling modulego/tritrpcvnext(mirroringreference/experimental/…_v4), rather than de-versioning v1 or leaning on Go semantic-import/v2path suffixes.Safety
Effectively non-breaking: the
example/placeholder is unresolvable, so no external importer can exist. Verified locally with Go 1.22:go build ./...,go vet ./...,go test ./...all pass.