Skip to content

Conversation

@slerdev
Copy link

@slerdev slerdev commented Aug 16, 2021

Hey!

Type: bug fix

Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines.
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

The old deprecated Twitch API was not working for us. It works with the following changes. For reference:

.. those that have not made requests to the v5 API before July 15, 2021 will no longer be able to access v5

Thanks 😺

slerdev and others added 2 commits August 16, 2021 21:56
Co-authored-by: ADmad <ADmad@users.noreply.github.com>
@ADmad
Copy link
Contributor

ADmad commented Aug 17, 2021

The failing test case needs to be fixed.

@slerdev
Copy link
Author

slerdev commented Aug 17, 2021

Thanks for the feedback. I suppose it means creating a mockClientResponse at testGetIdentitySuccess for TwitchTest.php?

I am not sure when I have time to do this.

@ADmad
Copy link
Contributor

ADmad commented Aug 17, 2021

Thanks for the feedback. I suppose it means creating a mockClientResponse at testGetIdentitySuccess for TwitchTest.php?

Yes.

I am not sure when I have time to do this.

Then we'll have to wait until someone has the time :).

@dv4mp1r3
Copy link

Hi everyone!
The test case was fixed here dv4mp1r3@914d838 but I don't understand why this error appeared https://github.com/dv4mp1r3/auth/actions/runs/3952861608/jobs/6768979888#step:6:106
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants