fix(ci): tritrpc-exec-conformance — build crate at rust/tritrpc_v1#37
Merged
Conversation
…ate never passed) The pinned TriTRPC commit has no root Cargo.toml; the crate lives at rust/tritrpc_v1 (bin src/bin/trpc.rs). Build in the crate dir and point the exec step at the real binary via TRPC_BIN. Fixtures paths were already correct. This gate has failed on every run since 2026-04-26; this makes it a real conformance check.
tools/run-tests and siblings were committed without the executable bit, so the conformance workflow failed with exit 126 the moment the build step was fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs a conformance gate that has failed on every run since 2026-04-26 (4/4 failures).
Root cause: the workflow runs
cargo build -p tritrpc_v1from the TriTRPC repo root, but the pinned commit (5874124) has no root Cargo.toml — the crate lives atrust/tritrpc_v1/(binsrc/bin/trpc.rs). Unrelated to the dependabot checkout bump that surfaced it.Fix: build inside the crate dir; introduce
TRPC_BINenv pointing atrust/tritrpc_v1/target/debug/trpc; exec step usesTRPC_BIN. Fixture paths (fixtures/vectors_hex_unary_rich.txt*) verified correct at the pin — untouched.This PR touches the workflow file, so the path filter triggers the gate on this PR itself — green checks here = the gate actually works.
🤖 Generated with Claude Code