Open
Conversation
vi-cat
force-pushed
the
feature/mdParserOptions
branch
from
8be0ea9 to
660b732
Compare
vi-cat
force-pushed
the
feature/mdParserOptions
branch
from
660b732 to
5f0154d
Compare
Author
|
Unit tests seem to be broken (as they are in master too), I will take a look. |
Igloczek
reviewed
Mar 25, 2020
Contributor
Yeah, that's unfortunately true, I didn't update them for some time, sorry about that :( |
vi-cat
force-pushed
the
feature/mdParserOptions
branch
3 times, most recently
from
92a7f9d to
cdbc36b
Compare
…nto feature/mdParserOptions
vi-cat
force-pushed
the
feature/mdParserOptions
branch
from
cdbc36b to
7ed8d70
Compare
vi-cat
force-pushed
the
feature/mdParserOptions
branch
from
da28207 to
5f5d80c
Compare
Author
|
@Igloczek I fixed the tests and the config overriding appears to work for me. Do you want to test my changes locally before merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get-config.jsto be a singleton